Backport PR #2718 to release/v1.7 for Fix bind DOCKER_OPTS option #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🐛 Fix bind DOCKER_OPTS option Signed-off-by: vankichi <kyukawa315@gmail.com> * Fix --------- Signed-off-by: vankichi <kyukawa315@gmail.com>
|
Caution Review failedThe pull request is closed. 📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request focus on modifying the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…x-docker-opts-bind
Deploying vald with
|
| Latest commit: |
320efb4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d750b3e.vald.pages.dev |
| Branch Preview URL: | https://backport-release-v1-7-ci-mak-2fai.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- Makefile.d/docker.mk (3 hunks)
🔇 Additional comments (1)
Makefile.d/docker.mk (1)
307-307: Review the DOCKER_OPTS binding fixThe changes use shell parameter expansion
${DOCKER_OPTS:+${DOCKER_OPTS}}to properly append build arguments to existing DOCKER_OPTS. This is a good practice as it:
- Preserves any existing DOCKER_OPTS values
- Handles the case when DOCKER_OPTS is unset or empty
Also applies to: 375-375, 398-398
vankichi
commented
Oct 25, 2024
vankichi
commented
Oct 25, 2024
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
kpango
approved these changes
Oct 25, 2024
kpango
deleted the
backport/release/v1.7/ci/makefile/fix-docker-opts-bind
branch
This was referenced Nov 14, 2024
This was referenced Dec 3, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
New Features
ZLIB_VERSIONandHDF5_VERSION.Bug Fixes
HDF5_VERSIONtoHDF4_VERSIONin relevant build targets.